Upgrade to rubocop 1.x #57
Conversation
|
does bixby want a version bump with this? 4.0.0? |
|
@no-reply I would expect that it would need a major version bump due to the required ruby version even if the rubocop rules don't change (which I expect they might slightly). If we're doing a major version then it would be good to try and clean things up a bit at the same time:
|
| @@ -795,7 +795,7 @@ Lint/UselessAccessModifier: | |||
| Lint/UselessAssignment: | |||
| Enabled: true | |||
|
|
|||
| Lint/UselessComparison: | |||
| Lint/BinaryOperatorWithIdenticalOperands: | |||
There was a problem hiding this comment.
This cop's name changed.
| RSpec: | ||
| Include: |
There was a problem hiding this comment.
rubocop-rspec moved and renamed this property.
| @@ -25,7 +24,6 @@ RSpec/DescribeMethod: | |||
|
|
|||
| RSpec/EmptyExampleGroup: | |||
| Enabled: true | |||
| CustomIncludeMethods: [] | |||
There was a problem hiding this comment.
This property is no longer supported by this cop.
| spec.add_dependency 'rubocop-ast', '~> 0.3.0' | ||
| spec.required_ruby_version = '>= 2.6' | ||
|
|
||
| spec.add_dependency 'rubocop', '>= 1', '< 2' |
There was a problem hiding this comment.
Should this use ~> instead?
| spec.add_dependency 'rubocop', '>= 1', '< 2' | |
| spec.add_dependency 'rubocop', '~> 1.0' |
| # Rubocop version, we will want to revisit this dependency. Either | ||
| # changing the version range OR removing it. | ||
| spec.add_dependency 'rubocop-ast', '~> 0.3.0' | ||
| spec.required_ruby_version = '>= 2.6' |
There was a problem hiding this comment.
Rubocop required setting this to match the TargetRubyVersion in the rubocop config.
| @@ -0,0 +1 @@ | |||
| inherit_from: bixby_default.yml | |||
There was a problem hiding this comment.
Eat our own dog food. 🐶
| @@ -162,9 +162,6 @@ Style/MethodCallWithoutArgsParentheses: | |||
| Style/MethodDefParentheses: | |||
| Enabled: true | |||
|
|
|||
| Style/MethodMissingSuper: | |||
There was a problem hiding this comment.
This cop changed to Lint/MissingSuper
Reverts the changes introduced with #57
Being stuck on an old version of rubocop is blocking allowing ruby 3.0+ in gems using bixby. With the release of rubocop 1 it has adopted semantic versioning which means that new cops will not be enabled until the next major release. This is why I've allowed any version of 1.x rubocop in the gemspec.
I think it is worth revisiting #32 and see if there is enough energy to continue maintaining community style defaults or if the main goal of this gem has been fulfilled with the release of rubocop 1.0.