Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing the Gem for promotion to Core Component #60

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

jrgriffiniii
Copy link
Contributor

This resolves #59

@cla-bot cla-bot bot added the cla-signed label Feb 24, 2022
@jrgriffiniii jrgriffiniii force-pushed the issues-59-jrgriffiniii-promotion branch from c7aa97c to 0599ebb Compare February 25, 2022 15:07
@jrgriffiniii
Copy link
Contributor Author

May I please request a review and merge from @samvera-labs/maintenance members (or, if available, @cjcolvar [sorry]) in order to ensure that this can be promoted to https://github.com/samvera. Thank you very much!

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I wonder if this needs to wait until promotion has been confirmed. What do you think?

@jrgriffiniii jrgriffiniii merged commit ac8d736 into main Mar 15, 2022
@jrgriffiniii jrgriffiniii deleted the issues-59-jrgriffiniii-promotion branch March 15, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify @jrgriffiniii as the product owner for bixby
3 participants