remove puma from .gemspec #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not actually a dependency of this gem; apps using this gem do not need puma installed, let alone a specific version of puma. Past commit message at 0a9ed02 suggested puma was needed here for circle-ci to succeed, but let's see if that's still true.
|
Not sure why coverage/coveralls is still stuck in expected/waiting -- that seems to be urnelated, because it's all true in other recent PRs, such as #317? Would it make sense to remove that as a required check, since it's not working? Other than that, all tests seem to be passing? This suggests that having puma in the gemspec is not required for circle-ci success, at least not currently? Since the commit message in 0a9ed0 when puma was added to gemspec suggests it was added in order to make circle-ci pass... if it is no longer required for circle-ci to pass, can it simply be removed? And then resolve #337, to to longer put restrictions on what version of puma (if any) a using application is using? |
jrgriffiniii
approved these changes
Apr 13, 2020
|
Thank you @jrgriffiniii , appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not actually a dependency of this gem; apps using this gem do not need puma installed, let alone a specific version of puma.
Past commit message at 0a9ed02 suggested puma was needed here for circle-ci to succeed, but let's see if that's still true.
Could resolve #337