Allow google_drive 3.x #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests work off of fixtures which have been generated for previous versions. I will merge this and then look to test this. Should I find any problems with the Gem, I will open new errors as issues. |
jrgriffiniii
approved these changes
Apr 13, 2020
|
This too requires a rebase. |
|
This one isn't saying there's a conflict requiring a rebase? But I can rebase after the other one requiring a rebase is merged. |
|
It's possible you will have to re-generate the fixtures to have confidence in the tests not sure. The migration notes say:
But also
And otherwise only mention google-sheets-related things. |
google_drive 3.0 came out November 2018. https://rubygems.org/gems/google_drive/versions/ Prior to this change, any app using browse_everything would be prevented from using google_drive 3.0. The backwards compat changes in google_drive 3.0 appear minimal and only related to "google sheets", which I don't believe browse_everything uses, so I believe it should Just Work to allow google_drive 3.0. If not, hopefully tests will catch it? https://github.com/gimite/google-drive-ruby/blob/master/MIGRATING.md#migrating-from-version-2xx
jrochkind
force-pushed
the
update_google_drive
branch
from
c3e60af to
40ae869
Compare
|
Rebased! Thanks @jrgriffiniii ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google_drive 3.0 came out November 2018. https://rubygems.org/gems/google_drive/versions/
Prior to this change, any app using browse_everything would be prevented from using google_drive 3.0.
The backwards compat changes in google_drive 3.0 appear minimal and only related to "google sheets", which I don't believe browse_everything uses, so I believe it should Just Work to allow google_drive 3.0. If not, hopefully tests will catch it?
https://github.com/gimite/google-drive-ruby/blob/master/MIGRATING.md#migrating-from-version-2xx