-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to first page for pdf images #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5528d4a
to
26d5acb
Compare
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black PDFs. Also add more class attributes to allow setting the options. See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120 Also add more class attributes to allow setting the options.
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120 Also add more class attributes to allow setting the options.
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 11, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120 Also add more class attributes to allow setting the options.
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 12, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn
added a commit
to dunn/riiif
that referenced
this pull request
Dec 14, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
jcoyne
pushed a commit
to sul-dlss/riiif
that referenced
this pull request
Dec 14, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last tweak, I hope.
For the PDF thumbnail generation to be effective, users would need to add the
layer: 0
directive to their application code, so instead let's just default it to the first layer if we're coming from a pdf. This also fixes another problem with thumbnails of office documents. Because we're passing a pdf to the image converter internally when we convert office documents to images, we won't need to specify a layer directive there either.Alternatively, we could pass a layer directive to the image processor from the document processor, and leave the existing image processor code unchanged, but that would still leave existing implementations with the task of overriding their
create_derivatives
methods to pass that layer directive in for all their other pdfs.This PR should make default hydra installations behave correctly, with multi-page PDFs and office documents converted to images using their first pages only, while allowing for specific layer directives should the user choose them.