Use first label to avoid smushing nested labels in more complex fields #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show a picture of the DOM before and after this fix? |
hackartisan
force-pushed
the
first-label
branch
from
b92167a to
9f0ff1a
Compare
|
before: after: |
hackartisan
force-pushed
the
first-label
branch
from
9f0ff1a to
1fdbf54
Compare
awead
approved these changes
Dec 8, 2016
| @@ -122,7 +122,7 @@ export class FieldManager { | |||
|
|
|||
| getFieldLabel($element, options) { | |||
| var label = ''; | |||
| var $label = $element.find("label"); | |||
| var $label = $element.find("label").first(); | |||
There was a problem hiding this comment.
@HackMasterA does .find always return an array, even if there's only one item?
There was a problem hiding this comment.
it's not really an array; it's a jquery object. but good question. it does always work with .first() and this doesn't mess up any of my other fields. i can add in a test case to demonstrate if you want although you just merged so that's sort of confusing :)
There was a problem hiding this comment.
@HackMasterA you're test appeared to cover the scenario I was questioning, so I think we're good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you've created more complex fields for, e.g., nested objects the "Add additional" link includes every label all mushed together. This is the fix.
@projecthydra/hyrax-code-reviewers