Split option-building from field-building #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure how to handle the comment about the index parameter - seems relevant to both functions, but I wasn't sure it made sense to have it twice. I'll change it / remove it / duplicate it / whatever if that's a concern. |
jcoyne
added a commit
that referenced
this pull request
Apr 17, 2015
Split option-building from field-building
|
When I merged this the build broke because it couldn't calculate a valid gemset. |
|
I think this PR ought to fix the brokenness: #86 |
|
Odd, sorry about that - I'm sure I ran tests :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows subclasses a bit more flexibility to build HTML fields and/or set options