Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates CircleCI for continuous integration #40

Merged

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #39. This is only a draft given that I'm still struggling to resolve the PATH issues for the FITS.

@jrgriffiniii jrgriffiniii force-pushed the issues-39-jrgriffiniii-circleci branch from 0e46c99 to bed707c Compare May 7, 2019 20:12
@coveralls
Copy link

coveralls commented May 7, 2019

Coverage Status

Coverage decreased (-0.2%) to 83.056% when pulling a33608d on jrgriffiniii:issues-39-jrgriffiniii-circleci into 2fe131b on samvera:master.

@jrgriffiniii jrgriffiniii force-pushed the issues-39-jrgriffiniii-circleci branch from bed707c to 1126011 Compare May 7, 2019 20:19
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a few questions.

spec/spec_helper.rb Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@jrgriffiniii jrgriffiniii force-pushed the issues-39-jrgriffiniii-circleci branch 3 times, most recently from 7a9686a to b12f5f5 Compare May 8, 2019 16:29
@jrgriffiniii jrgriffiniii marked this pull request as ready for review May 8, 2019 16:29
…b; Deprecating Travis CI as a continuous integration service
@jrgriffiniii jrgriffiniii force-pushed the issues-39-jrgriffiniii-circleci branch from b12f5f5 to a33608d Compare May 8, 2019 16:49
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tpendragon tpendragon merged commit 4d7ab76 into samvera:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CircleCI for continuous integration
4 participants