Added support for changing base fixture directory using path argument #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason we need to remove the use of FixtureLoader? I'd prefer we push more code into reusable libraries rather than rake tasks. |
|
I agree. I submitted this as a stop gap measure until I have a chance to get to HYDRA-741. If you think it would be better to wait until HYDRA-741 then that's fine. But until then repo:load in AF behaves differently than repo:load in HH which could be confusing (or not). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will detect if the path argument is a file or a directory to use along with the pid argument. This allows use of a base directory other than spec/fixtures/ .
I also replaced the code with the current code from the ActiveFedora load task with the change of the default fixture directory. I've tested the AF code, but I'm not certain if ActiveFedora::FixtureLoader works in all cases covered by the AF load task. I'll look into this later (HYDRA-741), but for now this should work.
This was requested by mkorcy.