add tests for better coverage of pcdm objects #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 4ef4026 on improve_object_tests into * on master*. |
awead
added a commit
that referenced
this pull request
May 12, 2015
add tests for better coverage of pcdm objects
| false | ||
| end | ||
|
|
||
| def ancestor? object |
There was a problem hiding this comment.
Please add comments about what this method does.
|
The code in question implements object hasMember object. It is directly modeled off the same code for collection hasMember collection in collection_behavior. methods: If changes need to happen to make this function better, then they need to happen there as well. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily extends pcdm object tests to make them consistent with testing for pcdm collection. This also added object hasMember object in the same way that collection hasMember collection.