Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to assign registered role on global tenant #1712

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

cjcolvar
Copy link
Member

On a fresh checkout of hyku, I was not able to register a user on the global tenant because the
before_create callback errored when trying to add the registered role
due to a validation error on the role: Resource type is not included in the list
This was not caught in the tests because there wasn't a check that the
user actually got created.

@samvera/hyku-code-reviewers

I was not able to register a user on the global tenant because the
before_create callback errored when trying to add the registered role
due to a validation error on the role: `Resource type is not included in the list`
This was not caught in the tests because there wasn't a check that the
user actually got created.
@orangewolf
Copy link
Member

guess I'll cross this off my list of things to get committed back from last week https://share.getcloudapp.com/RBul5JrP =-D

Also, i didn't see it before, but I think its the line feed in the original that is the problem. the unless would have a nil after it and the next line would evaluate true or false but not return to anything. Your way is cleaner and (obv) less error prone.

1 similar comment
@orangewolf
Copy link
Member

guess I'll cross this off my list of things to get committed back from last week https://share.getcloudapp.com/RBul5JrP =-D

Also, i didn't see it before, but I think its the line feed in the original that is the problem. the unless would have a nil after it and the next line would evaluate true or false but not return to anything. Your way is cleaner and (obv) less error prone.

@orangewolf orangewolf merged commit 11a28ae into main May 25, 2021
@orangewolf orangewolf deleted the user_create branch May 25, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants