83 datacite endpoint credentials save error #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working for me 🎉 |
selamhabteab
commented
Jul 15, 2022
| <%= s.input :mode, required: false %> | ||
| <h3><%= t(".data_cite_endpoint") %></h3> | ||
| <%= f.simple_fields_for :data_cite_endpoint do |s| %> | ||
| <%= s.input :mode, collection: ['test', 'production'], required: false %> |
There was a problem hiding this comment.
Undecided about select input. Will need reviewer to determine if it should be implemented or omitted.
jpengst
approved these changes
Jul 15, 2022
jpengst
approved these changes
Jul 15, 2022
laritakr
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 83 in UTK https://gitlab.com/notch8/utk-hyku/-/issues/83
Summary
Issue observed: DataCite Endpoint credentials do not save on the global /proprietor/accounts/#/edit form (AKA superadmin tenant account edit form). This blocks testing for DOIs.
Changes proposed in this pull request:
data_cite_endpointand added a select input for testing/production. Undecided about select input. Will need reviewer to determine if it should be implemented or omitted.