1837 better user error handling #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishaevn
commented
Aug 17, 2022
| <li><%= key %> "<%= @user.errors.details[key].first[:value] %>" <%= messages.join(' and ') %></li> | ||
| <% end %> | ||
| <% next unless messages.present? %> | ||
| <li><%= key %> <%= messages.join(' and ') %></li> |
There was a problem hiding this comment.
removed @user.errors.details[key].first[:value] because it doesn't exist per the screenshots below. unsure if it is supposed to or not.
if [:value] is supposed to exist, we should instead fix why it isn't showing up in the details array.
There was a problem hiding this comment.
user "new" view page
user controller
orangewolf
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected behavior
@user.errors.details[key].first[:value]because it does not existrelated
@samvera/hyku-code-reviewers