Fix shared search URLs

[laritakr]

Fixes remaining problems with UTK issue 80

Blacklight's search_context.js introduces click-jacking behavior for A-tags that conflict with shared search tenant behavior. This click-jacking behavior uses a relative path in its form submission.

The manifestation of this problem is when you click on an item in the shared search tenant catalog index and get a Faraday error that has the port 99999. That 99999 means that there’s no loaded tenant the various endpoints (see AccountEndpoints module) for Solr and Fedora use the nil handler and our nil endpoint handler is loaded. See the NilSolrEndpoint. This is evident in the work of UTK issue 80, where we coerced an ID (which normally renders as a path) to a URL to the host tenant.

To remedy the link jacking, we have two options:

1. Amend Blacklight::UrlHelperBehavior#document_link_params to ignore the the session_tracking_params method call when dealing with a full URL.
2. Amend Blacklight::UrlHelperBehavior#session_tracking_path to return a URL instead of a relative path.

Changes proposed in this pull request:

• Use the first of the two options listed above to allow full links to resolve
• Remove CatalogHelperBehavior overrides which are now obsolete
• Remove partials previously overridden from Hyrax which are no longer needed due to this change

@samvera/hyku-code-reviewers

[ShanaLMoore]

I know you are leaving for the day so I plan to correct this @laritakr

[ShanaLMoore]

Taking this for a spin, after I created a work w a fileset for each tenant. I then made a collection. I was going back to the work's show page to add the work to the collection but ran into this error:

Not sure if it's related to the changes in this PR but I'd like to take some time to look into it and maybe correct it here if so.

[ShanaLMoore]

Taking this for a spin, after I created a work w a fileset for each tenant. I then made a collection. I was going back to the work's show page to add the work to the collection but ran into this error:

Not sure if it's related to the changes in this PR but I'd like to take some time to look into it and maybe correct it here if so.

The issue is that from the catalog controller, doc is a solr document. but from the work show page it's a fileset presenter and calling to_h doesn't work in that context.

[ShanaLMoore]

@laritakr I pushed up what I think may be the fix to the issue described above. Please review at your convenience.

• I tested that the shared search links and links via thumbnails are all going to the correct place.
• I also tested that the thumbnails on the work's show page still work

I approve this PR if you agree with my changes. Otherwise ping me again when this is ready, if you decide to do something different to resolve it.

Demo: https://share.getcloudapp.com/X6uQAJBN
Screenshots:

[ShanaLMoore]

As an update, I pulled over the fix from UTK. I retested it and it's all still working.

[laritakr]

Thanks for following up, @ShanaLMoore The changes you made are what I had in mind.