Move Blacklight URL Helper overrides #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2022 13:40
BlacklightHelperBehavior includes BlacklightUrlHelper, so moving them here includes them along with the other Blacklight overrides. Moving them also solves issues with UTK not including handling Blacklight overrides, and simplifies future Hyku upgrades by keeping them in synch.
ShanaLMoore
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlacklightHelperBehavior includes BlacklightUrlHelper, so moving overrides includes them along with the other Blacklight overrides. Moving them also solves issues with UTK not including handling Blacklight overrides, and simplifies future Hyku upgrades by keeping them in synch.
Ref #80
@samvera/hyku-code-reviewers