disable-analytics-env-also-dont-error-if-not-enabled #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ics isnt enabled yet, also lets comment out the env file since tests use it and google is not needed
labradford
approved these changes
Jan 10, 2023
labradford
previously approved these changes
Jan 10, 2023
bkiahstroud
deleted the
disable-analytics-env-also-dont-error-if-not-enabled
branch
|
Ref #1882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rspec spec/features/create_generic_work_spec.rb
Rspec feature test was failing due to not being able to access the dashboard because Google Analytics was enabled by default (half-setup) and no p12 file to allow the feature test to access the dashboard so adding a check to see if google analytics is setup and commenting out the analytics env variables in the env file.