Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iiif print demo copy #1926

Merged
merged 16 commits into from
Mar 15, 2023
Merged

Iiif print demo copy #1926

merged 16 commits into from
Mar 15, 2023

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Feb 28, 2023

Summary

Installed IiifPrint with basic default configurations. This work has been deployed to: https://demo.hyku-iiif.notch8.cloud/

Upgrade Bulkrax to v5.0.0 due to required dependencies for iiif_print.

Screenshots / Video

SAMPLE FILE: iiif-print-test.pdf

PDF Splitting. Importing a pdf that has multiple pages should create a child work for each page.

image

Parent OCR search for child data (metadata or ocr)

image

Catalog Search for child data (metadata or ocr) should not return the child works

image

Expected Behavior

User should be able to perform all that's listed in the features list's user story tab

Notes

this branch is iiif-print-demo + the changes to improve the solr build.

I want to verify that the build issues are resolved with this branch/PR, before merging in the code. ✅

@ShanaLMoore
Copy link
Collaborator Author

The issue still exists. Solr is not creating a core.

image

@orangewolf orangewolf reopened this Feb 28, 2023
@ShanaLMoore ShanaLMoore added the major-ver for release notes label Mar 1, 2023
@ShanaLMoore ShanaLMoore marked this pull request as ready for review March 1, 2023 19:37
@ShanaLMoore ShanaLMoore requested a review from orangewolf March 1, 2023 19:37
@ShanaLMoore
Copy link
Collaborator Author

The issue still exists. Solr is not creating a core.

image

RESOLVED ✅

Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. we should likely note in the PR description that this also upgrade Bulkrax to 5.0, just so that fact is not lost in the release notes

@ShanaLMoore
Copy link
Collaborator Author

This looks good. we should likely note in the PR description that this also upgrade Bulkrax to 5.0, just so that fact is not lost in the release notes

done ✅ good point

@ShanaLMoore ShanaLMoore merged commit 06aa20d into main Mar 15, 2023
@ShanaLMoore ShanaLMoore deleted the iiif-print-demo-copy branch March 15, 2023 15:19
@orangewolf orangewolf removed the major-ver for release notes label Nov 29, 2023
@orangewolf orangewolf added the minor-ver for release notes label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants