Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes work/edit form error flash messages #1947

Merged
merged 1 commit into from
May 8, 2023

Conversation

summer-cook
Copy link
Collaborator

@summer-cook summer-cook commented May 4, 2023

Fixes work/edit form error flash messages

This was implemented in atla-hyku

Story

Error messages from validations in the edit-work form were appearing as blank- the message was not being parsed correctly. This PR updates the works controller behavior to make sure that these error messages are being set.

Related

Expected Behavior Before Changes

  • users would see a blank error message
    Image

Expected Behavior After Changes

  • users will not see a blank error message at the top of the screen

Screenshots / Video

Working error message for :video_embed

screencapture-bulkraxtest-hyku-test-concern-generic-works-2023-05-04-11_15_40

@samvera/hyku-code-reviewers

@summer-cook summer-cook added the patch-ver for release notes label May 4, 2023
@bkiahstroud bkiahstroud merged commit da91af3 into main May 8, 2023
@bkiahstroud bkiahstroud deleted the fix-validation-flash-msg-work-edit-form branch May 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants