Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code comment and reverts a rubocop change that breaks theming #1950

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

labradford
Copy link
Collaborator

Fixes #1949

Running rubocops autocorrect mistakenly changes the calling of the view_paths= method into a variable assignment. This PR fixes a previously changed instance, and add code comments to each of the calling of the view_paths= method to prevent this change from happening again.

@samvera/hyku-code-reviewers

@labradford labradford merged commit 77e13e0 into main Jun 1, 2023
@labradford labradford deleted the fix-view_paths-method branch June 1, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view_paths=(paths) method keeps getting mistakenly corrected by rubocop
2 participants