🐛 Fix depositor role issue #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2023 12:09
We implemented a fix for this bug in PALS and are contributing it back to Hyku. Issue: - notch8/palni-palci#864
We implemented a fix for this bug in PALS and are contributing it back to Hyku. Issue: - notch8/palni-palci#864
bkiahstroud
previously approved these changes
Oct 25, 2023
bkiahstroud
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented a fix for this bug in PALS and are contributing it back to Hyku.
Ref:
Expected Behavior Before Changes
Prior to this commit, even if a user was granted the role of depositor to an admin set, they could not add a work. If they were added in a group that had the depositor role, they still were not able to create a work.
Expected Behavior After Changes
Now, users who have the depositor role or in a group with the depositor role can deposit to admin sets.
Screenshots / Video
Screen.Recording.2023-10-18.at.16.09.56.mp4
NOTE
By default Hyku doesn’t actually include everyone_can_create_curation_concerns in the ability logic. It’s behind an ENV-controlled feature flipper, which by default is true (true in this case does not include everyone_can_create_curation_concerns since true == more restrictive permissions)