Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Email Notifications #2302

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Batch Email Notifications #2302

merged 9 commits into from
Aug 22, 2024

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Aug 22, 2024

Refs notch8/palni_palci_knapsack#121

last_emailed_at was previously added to the User table. However User table is not tenant-specific, and this date needed to be unique to each tenant. This moves the last_emailed_at date to its own table and modifies the use to match the new location.

LaRita Robinson added 5 commits August 21, 2024 16:37
Removes last_emailed_at from Users and generates UserBatchEmails table
containing the date instead.
Updates User and creates UserBatchEmail models.
Adjust job to accommodate new table.
@laritakr laritakr added the patch-ver for release notes label Aug 22, 2024
db/schema.rb Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 22, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 16s ⏱️ - 1m 11s
2 032 tests ±0  1 982 ✅ +1  50 💤 ±0  0 ❌  - 1 
2 059 runs  ±0  2 007 ✅ +1  52 💤 ±0  0 ❌  - 1 

Results for commit 202f21c. ± Comparison against base commit 4a1505f.

This pull request removes 44 and adds 44 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 84eb9c0f-8e5a-4949-9fe0-83a6366b4e97
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 9b0a703d-4543-4b19-bf40-72497990a2f7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read fded177b-a711-432a-b4ed-a8742d295079
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update e2e462aa-6809-4a98-be10-4e28241d6b7e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a9ec169d-4e18-40d2-b61b-75b5d5296571
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit d25d7031-7679-4217-9d56-fc8901b4a823
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 70565109-eb41-422e-bd28-133283340ea7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update ed101e79-cecc-4052-aeae-6cf6ae242ef3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 0835d10b-5ae4-4379-89b9-11fd0f796412
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 6c34e47b-33b2-4b6f-ba02-21a7c008c9c0
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 2af6a550-bbb4-457d-b2fe-583a16ac328f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 7027d459-8353-46ea-b35e-af257fbb0aa4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ac2813ef-c686-4af5-b216-96333e8d7dab
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 34659930-b888-4664-b891-b478780782c6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 7d2301bc-bc94-4299-b687-94cc62458c6c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit b9fb26c4-f0d4-48a0-a410-28255579e4f2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 5ac0fdcf-9ca9-4116-9c50-ca865cdde788
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 1083f073-ad12-4b43-a844-497ffb5dda77
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy c1f2c955-e932-4861-a3ad-489b98f531fa
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 68c81e52-7bb8-4d5b-8aa1-ad09ae470a55
…

♻️ This comment has been updated with latest results.

LaRita Robinson added 2 commits August 22, 2024 13:45
@ShanaLMoore ShanaLMoore requested a review from orangewolf August 22, 2024 19:38
sjproctor
sjproctor previously approved these changes Aug 22, 2024
Copy link
Collaborator

@sjproctor sjproctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go other than the db/schema.rb change.

@laritakr laritakr merged commit af9b198 into main Aug 22, 2024
8 checks passed
@laritakr laritakr deleted the pals-i121-batch_email branch August 22, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants