-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Email Notifications #2302
Conversation
Removes last_emailed_at from Users and generates UserBatchEmails table containing the date instead.
Updates User and creates UserBatchEmail models.
Adjust job to accommodate new table.
Test Results 3 files ±0 3 suites ±0 17m 16s ⏱️ - 1m 11s Results for commit 202f21c. ± Comparison against base commit 4a1505f. This pull request removes 44 and adds 44 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go other than the db/schema.rb change.
Refs notch8/palni_palci_knapsack#121
last_emailed_at
was previously added to the User table. However User table is not tenant-specific, and this date needed to be unique to each tenant. This moves thelast_emailed_at
date to its own table and modifies the use to match the new location.