Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Adjust show pages #2416

Merged
merged 2 commits into from
Jan 16, 2025
Merged

🧹 Adjust show pages #2416

merged 2 commits into from
Jan 16, 2025

Conversation

kirkkwang
Copy link
Collaborator

This commit will adjust the show pages of various themes and make them look better.

Default show:
image

Cultural show:
image

Scholarly show:
image

@kirkkwang kirkkwang added the patch-ver for release notes label Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 38s ⏱️ +6s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit b060289. ± Comparison against base commit be514fc.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e48e77bf-9c46-4941-b095-58215cdfe110
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 4f261fd8-fc57-4f46-82ed-845e36428d6f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 1075efbe-adce-42ca-b9b4-02ed6f41e04e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ae9d9d72-d160-4765-a8b2-847f7de80be7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 161a7e18-136e-45ac-991a-7f44c08e5321
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a69d3f76-75ed-4d03-b051-a7069297a4ba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 709b6b6c-b0ec-475a-b662-278bd65b7737
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 70c7066c-87fd-4721-ad57-1cc1b7b7cbf9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 49095632-2b40-4971-8311-56a6c8854a95
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 15078b98-64df-43a3-8a01-2504af1574f5
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 10e78497-cd89-4cff-8820-8261f7654f6d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit c3f4bc9e-5b1a-4512-892a-45b13498f03d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 84cebf90-afb0-4c9b-88bf-ad4e09bcdbbf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c35fa2e5-008e-4770-bb55-298d68c0c978
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 6eff7a65-2ac2-44d1-8218-9bbb762937f5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 144d90c5-a4bf-454e-a37d-f70828550cb2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 16c106c4-46e4-492c-bd1d-4e4cfe70b3a6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update eba05964-4a16-4994-a7c2-c1eac2c482ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 746db493-56d4-4705-9128-3e0aece61a2c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit de9076c2-6247-4da7-8d01-a489efd43618
…

♻️ This comment has been updated with latest results.

This commit will adjust the show pages of various themes and make them
look better.
This commit will return the account back to the default after the
create_account_spec is run to it doesn't interfere with other specs.
@kirkkwang kirkkwang merged commit 843705e into main Jan 16, 2025
8 checks passed
@kirkkwang kirkkwang deleted the adjust-show-pages branch January 16, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants