Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct range limit helper inclusion in SearchHistoryController #2418

Closed
wants to merge 1 commit into from

Conversation

ShanaLMoore
Copy link
Collaborator

Changed helper Blacklight::RangeLimitHelper to include BlacklightRangeLimit::ControllerOverride since the proper module for range limit functionality is provided by the BlacklightRangeLimit engine's ControllerOverride module rather than through a helper method. This module provides the necessary controller-level range limit behavior while maintaining proper Rails engine namespace isolation.

When updating the PALS submodule to HYKU latest we got the following errors in the pipeline. Updating this resolved it.

uninitialized constant SearchHistoryController::RangeLimitHelper

Changed helper Blacklight::RangeLimitHelper to include BlacklightRangeLimit::ControllerOverride since the proper module for range limit functionality is provided by the BlacklightRangeLimit engine's ControllerOverride module rather than through a helper method. This module provides the necessary controller-level range limit behavior while maintaining proper Rails engine namespace isolation.
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Jan 16, 2025
Copy link

Test Results

    3 files  ±  0      3 suites  ±0   13m 1s ⏱️ - 4m 31s
1 377 tests  - 678  1 342 ✅  - 657  34 💤  - 22  1 ❌ +1 
1 396 runs   - 686  1 358 ✅  - 666  36 💤  - 22  1 ❌ +1  1 🔥 +1 

For more details on these failures, see this check.

Results for commit 40cfc15. ± Comparison against base commit be514fc.

This pull request removes 718 and adds 40 tests. Note that renamed tests count towards both.
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility create_any when there are collection types that have create access allows create_any
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility create_any when there are no collection types that have create access denies create_any
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Editor role through its User roles allows most abilities but denies ability to destroy and manage discovery
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Editor role through its group memberships allows most abilities but not destroy nor manage_discovery
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Reader role through its User roles allows read abilities but denies others
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user has a Collection Reader role through its group memberships allows read abilities but denies others
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user is a Collection Manager through its User roles allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when a user is a Collection Manager through its group memberships allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when admin user allows all abilities
spec.abilities.collection_ability_spec ‑ Hyrax::Ability::CollectionAbility when collection depositor allows deposit related abilities and denies non-deposit related abilities
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy c9b39bc2-32ef-42d8-8ba6-cac8f3bc52b9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 05c63d05-c060-49ae-9fda-789f88f00aa0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f399c09a-57ec-413d-9656-d106d39bf988
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c1d1404d-11fc-4f33-97a9-ac700bddb600
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3407dc3d-f300-4049-9ec5-d895d3158e9e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4e82d1e2-bbf8-48d9-b9e5-aa39b60dfad9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 58f3db63-2e25-4f3c-a684-cdcced248066
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 1c2ea8cf-400e-47aa-ba64-354394bbbae8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 9c000e1c-cf6f-4304-9457-418daab6008c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 08fac27d-7604-419d-b988-5e4828f009b8
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant