Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Switch from bootstrap class to css #2419

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kirkkwang
Copy link
Collaborator

This commit will change the cultural show page's citations div to use css instead of using bootstrap utility classes. This way it will be easier for knapsack applications to override the style of that div.

This commit will change the cultural show page's citations div to use
css instead of using bootstrap utility classes.  This way it will be
easier for knapsack applications to override the style of that div.
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 49s ⏱️ -20s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 34fd1ee. ± Comparison against base commit 843705e.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7c56ffd7-f068-4501-9dec-696a974d33ee
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit da5c97d9-6b51-4d05-b12e-979fb36af644
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 237268ed-11d5-421d-92a1-05b0f30180b1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update a0387adf-f772-41d9-8b95-074bb63f2e31
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 173f47fb-95b9-4d96-a296-812582a726ef
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6eb1fb28-ac85-4b64-b1f1-4840b89153a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read aced0675-12d1-4126-a59a-b4a3da1116ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update f3689d8c-3e03-4bd8-848d-523dc9d4bc1e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 0418374b-059c-4751-82b2-c56509a3e2ea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 56ee4da9-346f-435e-bf81-05e7cb2ce869
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 4cbf1afc-04b0-4104-8c65-bc10f3c0c9db
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 6196c528-d801-41df-b797-8486d48d902d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 290ecc83-70b0-4f84-a64b-5cfb3e5b9cd7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 7642362f-41e8-4726-be65-26dddfcc8aed
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy e1914842-82cd-42a2-ab28-8ae06dd0c4a7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 57169047-9dcf-4cfb-982a-33aa9072ab1c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read fda21153-907b-4307-b9d3-42f217ee188c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update b7e6d44b-ed18-49ff-9c91-df79002bfd38
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 95f84232-7309-4e50-9e14-036b39cb3a16
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 19d99e1e-9df0-470f-9302-2e2d1b2c6a23
…

♻️ This comment has been updated with latest results.

@kirkkwang kirkkwang merged commit 92d95f8 into main Jan 16, 2025
9 checks passed
@kirkkwang kirkkwang deleted the adjust-cultural-show-citations-div branch January 16, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants