Move SolrService deprecation target to 4.0 #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
previously approved these changes
Sep 5, 2019
added 2 commits
September 6, 2019 10:38
The new interfaces will first be released in 3.0.0, so we can't remove the old ones until 4.0.
|
I suspect there's something up with the build cache. Other PRs are failing with similar errors. I can't look into it until later today, though. |
|
If my assumption is true, a bump to |
no-reply
force-pushed
the
instance-deprecation
branch
from
188a0bf to
d465d2a
Compare
|
actually, i'm pretty sure that's the deal. rebase in (and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new interfaces will first be released in 3.0.0, so we can't remove the old
ones until 4.0.
@samvera/hyrax-code-reviewers