Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the configured storage adapter #4217

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Use the configured storage adapter #4217

merged 1 commit into from
Jan 27, 2020

Conversation

no-reply
Copy link
Contributor

We weren't respecting storage adapter configuration for valkyrie! This fixes that.

@samvera/hyrax-code-reviewers

@no-reply
Copy link
Contributor Author

@elrayle this fixes an issue in Hyrax::FileMetadata, but i think there's a bigger problem, which is that #file doesn't seem to mean anything at all(?).

it looks like this method, and #valid? are with respect to an arbitrary id from #file_identifiers? can these just be removed? or should #file_identifiers be replaced with a singular #file?

@no-reply no-reply requested a review from elrayle January 25, 2020 05:19
We weren't respecting storage adapter configuration for valkyrie! This fixes
that.
@no-reply no-reply force-pushed the storage-adapter-conf branch from 440707b to 961aeb8 Compare January 25, 2020 05:28
@jeremyf jeremyf merged commit bccd86e into master Jan 27, 2020
@no-reply no-reply deleted the storage-adapter-conf branch January 27, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants