Add indexer to work_resource generator #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure seems unrelated to my change, and only on one of the circles. |
ghost
mentioned this pull request
ghost
force-pushed
the
generate-indexer
branch
from
0d69713 to
b9d3689
Compare
|
I think the failure here is because I need to create a new .internal_test_app (circle orb?). Help?! |
|
@geekscruff you need to bump the number in this is our current, slightly hacky---suggestions welcome!---way to handle changes that require bumps for reasons not detected by the circle config. |
|
I pushed the |
jeremyf
added a commit
that referenced
this pull request
Jan 27, 2020
Per #4219 > @geekscruff you need to bump the number in .regen. > > this is our current, slightly hacky---suggestions welcome!---way to > handle changes that require bumps for reasons not detected by the > circle config.
no-reply
reviewed
Jan 27, 2020
ghost
force-pushed
the
generate-indexer
branch
from
f4dc2f2 to
930b5fe
Compare
jeremyf
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an indexer to the work_resource generator, eg.
MonographIndexer. The indexer is configured to register the resource-specific Indexer, and adds a commented out exampleto_solr. Registers the new indexer inconfig/initializers/indexers.rb.Corrects
rails generate hyrax:worktorails generate hyrax:work_resourcein other templates.Adds
config/initializers/indexers.rbto the install generator (via hyrax:config generator).Adds a test to ensure the correct Indexer is returned by
Hyrax::ValkyrieIndexer#forfor a generated resource.