Update versioning service to support Valkyrie #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
reviewed
Oct 3, 2022
|
i think the extension of i'm pretty happy with the tests as-is. they seem appropriately scoped to the interface on VersioningService. the only thing that comes to mind is that a "many" case might be wanted (in addition to "one" and "two", or in place of "two"), but i wouldn't block on it, especially given how the implementation depends on 👍🏻 |
no-reply
previously approved these changes
Oct 3, 2022
- Allow instances of `VersioningService` to be created and used to access the versions of a resource - Update the Wings `Version` struct to support some additional properties needed by the versioning presenter (namely `created`) - Initial set of tests for Valkyrie versioning behaviour
marrus-sh
force-pushed
the
valkyrie-versioning
branch
from
638740c to
55e60a7
Compare
Also adds tests for `#versions` in VersioningService in addition to the existing static method tests.
marrus-sh
force-pushed
the
valkyrie-versioning
branch
from
9299dba to
ad4c320
Compare
no-reply
reviewed
Oct 3, 2022
no-reply
previously approved these changes
Oct 3, 2022
no-reply
previously approved these changes
Oct 3, 2022
This makes the presenter code cleaner and provides a standard fallback when attempting to access versioning for a file which does not exist.
marrus-sh
force-pushed
the
valkyrie-versioning
branch
from
416b78c to
564c60b
Compare
no-reply
approved these changes
Oct 4, 2022
dlpierce
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VersioningServiceto be created and used to access the versions of a resourceVersionstruct to support some additional properties needed by the versioning presenter (namelycreated)See #5876.
Things I’m curious about:
VersioningServiceacceptable?