Update show.json.jbuilder #6122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test skipping converting Hyrax::Resource objects back to ActiveFedora::Base objects because both support class.fields.
|
Hi @cjcolvar, thanks for the test The commented line: @curation_concern = Wings::ActiveFedoraConverter.convert(resource: @curation_concern)Caused a significant delay in generating the json response, so commenting it out considerably improved response times when consuming json from a SPA, which would be my case. |
|
There were missing keys from the generated JSON so the original reason for the conversion seems valid. I'm not sure what keys are dropped and if they're important though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test skipping converting Hyrax::Resource objects back to ActiveFedora::Base objects because both support class.fields.