-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible views #6859
Merged
Merged
Flexible views #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files ± 0 17 suites ±0 2h 7m 38s ⏱️ - 11m 53s For more details on these failures, see this check. Results for commit 552d564. ± Comparison against base commit 52af985. This pull request removes 291 and adds 303 tests. Note that renamed tests count towards both.
|
kirkkwang
approved these changes
Jun 28, 2024
Add view details. Try to standardize all 3, with only necessary differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs
view_properties
method on work presenter's schema service notch8/amigos#30attribute_rows
partial to dynamic usingview_properties
method notch8/amigos#31Summary
Building on prior work to dynamically render attributes for the simple schema, this implements a very basic view of attributes on a resource's show view for flexible schemas. More detail is needed in the sample m3 profile to fill in other options (such as
render_as
and locale details)I currently have it set up to use the most recent schema for view definition, since we don't want to have to edit, save, and index every work if we change something regarding views.
As long as a term has a basic
view:
definition section in the schema, it will render from the attributes partial:label:
string is provided, the label will be renderedScreenshots