Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @ to service id and type for backwards compatibility #70

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Add @ to service id and type for backwards compatibility #70

merged 2 commits into from
Oct 3, 2022

Conversation

kirkkwang
Copy link
Contributor

According to pres 3 specs and a conversation with Glen Robson, because ImageService2 is an older specification, the id and type need to be @id and @type

  • add @ to service id and type
  • adjust specs

cjcolvar
cjcolvar approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@cjcolvar cjcolvar merged commit babb39c into main Oct 3, 2022
@cjcolvar cjcolvar deleted the backwards-compatibility branch October 3, 2022 13:36
@cjcolvar cjcolvar mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkkwang @cjcolvar