Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ruby 2.7.z and Rails 6.y.z releases to the CircleCI build configuration #113

Merged

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #111 and #112

Comment on lines 51 to 54
- bundle_and_test:
name: ruby2-4_rails6-0
ruby_version: 2.4.6
rails_version: 6.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rails 6 requires ruby 2.5+

Comment on lines 60 to 64
- bundle_and_test:
name: jruby9-1_rails6-0
ruby_type: jruby
ruby_version: 9.1.17.0
rails_version: 6.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like jruby 9.2.x is compatible with ruby 2.5.x so jruby 9.1 can be dropped as not supported by rails 6.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrgriffiniii jrgriffiniii merged commit 2ab6604 into samvera:master Jan 29, 2020
@jrgriffiniii jrgriffiniii deleted the issues-111-jrgriffiniii-ruby-2.7 branch January 29, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Ruby 2.7.z releases
2 participants