Merge pull request #876 from samvera/file_close

Files should respond to #close.
samvera · Oct 18, 2021 · 5ca68fa · 5ca68fa
2 parents 60b5a4f + 5db467b
commit 5ca68fa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/valkyrie/specs/shared_specs/file.rb b/lib/valkyrie/specs/shared_specs/file.rb
@@ -9,6 +9,7 @@
   it { is_expected.to respond_to(:read) }
   it { is_expected.to respond_to(:rewind) }
   it { is_expected.to respond_to(:id) }
+  it { is_expected.to respond_to(:close) }
   describe "#disk_path" do
     it "returns an existing disk path" do
       expect(File.exist?(file.disk_path)).to eq true

diff --git a/lib/valkyrie/storage_adapter.rb b/lib/valkyrie/storage_adapter.rb
@@ -67,7 +67,7 @@ def adapter_for(id:)
     class File < Dry::Struct
       attribute :id, Valkyrie::Types::Any
       attribute :io, Valkyrie::Types::Any
-      delegate :size, :read, :rewind, to: :io
+      delegate :size, :read, :rewind, :close, to: :io
       def stream
         io
       end