Implement Deprecations in Preparation for Valkyrie 2.0 #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpendragon
changed the title
|
The frozen attributes thing is something in Figgy we were depending on not being the case. Trying to find a way to deprecate it now. |
tpendragon
force-pushed
the
prepare_for_2
branch
from
3ec7c77 to
38b5fea
Compare
tpendragon
changed the title
|
Confirmed this works in Figgy. |
tpendragon
force-pushed
the
prepare_for_2
branch
2 times, most recently
from
b42c3fb to
8f28f1b
Compare
|
pulibrary/figgy#2256 is the PR for Figgy that fixes deprecations that are reported here. |
|
Confirmed this works in Cho, and the deprecations are easily fixed: psu-libraries/cho@master...tpendragon:2_0_deprecations |
carolyncole
requested changes
Dec 3, 2018
tpendragon
force-pushed
the
prepare_for_2
branch
from
8f28f1b to
961407d
Compare
carolyncole
approved these changes
Dec 3, 2018
tpendragon
force-pushed
the
prepare_for_2
branch
from
961407d to
28be265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are deprecations we've discovered are necessary via upgrading to the latest version of dry-struct.