raise a more informative NoMethodError for missing custom queries #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
better-no-method-error
branch
2 times, most recently
from
9783137 to
c35d293
Compare
added 2 commits
September 20, 2021 16:01
the custom query container used to raise:
NoMethodError: undefined method 'new' for nil:NilClass`
this error doesn't do much to help callers figure out where they've gone
awry. the updated message includes:
- the originally called method name
- the list of available methods to call (as a kind of 'did you mean' feature)
- reference to the idea that queries need to be registered
hopefully these are all helpful reminders in dubugging.
tpendragon
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the custom query container used to raise:
this error doesn't do much to help callers figure out where they've gone
awry. the updated message includes:
hopefully these are all helpful reminders in dubugging.