Back up blob archives and fix saving blob columns #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change type hint to indicate that `imshow_multichannel` does not take a scalar as channel. Update `setup_channels` to use type hints.
…n set up Accessing a blob column of None has unintentionally added an axis to the blobs. A column of None is given when the column is missing from the blob, so the blob column accessor now returns None or an empty array depending on the blobs dimensions if the column is None.
Check image value for None directly. Also, fix docstring to indicate that the attribute is an Image5d instance.
- Remove the channel from the shape before reversing the order - Remove unused ROI to Image5d array call
Pass the channel as a sequence as required for the plotter.
Formatting blobs with additional columns has not added mappings for the new columns to their column indices, fixed here. The mapped columns are now saved instead of the loaded columns in case the mapping has changed.
Add a parameter that allows setting a mask for the first axis, defaulting to an index expression that gets all rows. Change specific column setters to pass args/kwargs to reduce redundancy.
Decrease potential noise from debugging messages during blob detection.
Avoid overwriting an existing blobs archive.
- Change from int to optional sequence of ints since this value is set up as a list from the CLI - Change channel setup type hint to allow channel to be None
…he ROI When extracting blobs during GUI detections, the blobs is an empty array rather than None, which led to an error when getting a discrete colormap based on the blob channels, fixed here.
Provide an error message and return immediately when no channels are selected during blob detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're splitting out the blob changes from the classifier branch (#199) here for modularity and to integrate them sooner.