Fix updating metadata format #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles Loading metadata first attempts to load the file as YML format. If the metadata has not been updated to YML format, the load typically results in a file not found error because main image reader formats the metadata path as a `.yml` file. When the user specifies metadata directly through the `--meta` flag, however, the YML loader attempts to read the NPZ file and gives a Unicode decode error. Catch both file not found and unicode errors in the main YML loader function, raising a single file not found error, which the metadata loader already catches. Additionally, remove the unused Numpy import statement in the YML I/O module.
Image metadata loaded through the main reader as NPZ files have been automatically resaved in YML format, but metadata loaded outside of this reader are not resaved. Integrate the YML saving into the metadata loader to resave the metadata whenever it is loaded as NPZ format, even if the file will be resaved later after any metadata updates. Also, convert warning calls to logger calls for consistency.
Catch YML load errors when attempting to load profile files. Also, convert debugging print calls to logging calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
This PR fixes loading metadata loaded in the prior, NPZ file format, when loaded directly, using the
--metacommand-line argument. File not found and Unicode errors are integrated directly into the YML load wrapper, and the file resaving as YML format is integrated into the metadata loader. Profiles loaded as YML files also catch load errors.