Make Mayavi optional #455
Merged
Make Mayavi optional #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Mayavi package provides 3D viewing but is not essential to the rest of the application. Move the package into a `3d` optional dependencies group, installed in the `all` but not the `most` group. Provide user instructions to install Mayavi when attempting 3D viewing.
Remove extra space if `task` is not provided.
Limit version exclusion to 5.15.8 since 5.15.9 appears to launch without error.
- Regenerate requirements without the Mayavi dependency - Python 3.6 requirements simplified to not include version-specific dependencies since the listing is only meant for Python 3.6
- Summarize installation groups in a table - Remove listing of dependency types - Small description simplifications - Add FAQ on Mayavi installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #401.
The Mayavi package provides 3D viewing but is not essential to the rest of the application. Mayavi installation has also been causing sporadic errors, which can interrupt environment setup for MagellanMapper.
This PR moves the package into a
3doptional dependencies group, installed in theallbut not themostgroup. When users attempt to 3D viewer, instructions are provided to install Mayavi via Pip.