Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textAlign flow relative polyfill #183

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Fix textAlign flow relative polyfill #183

merged 2 commits into from
Nov 21, 2020

Conversation

palemieux
Copy link
Contributor

Closes #177

@palemieux palemieux self-assigned this May 31, 2020
@palemieux palemieux added this to the 1.1.2 Release milestone May 31, 2020
@palemieux palemieux mentioned this pull request May 31, 2020
Closed
cconcolato
cconcolato reviewed Jun 1, 2020
View reviewed changes
src/main/js/html.js

context.ipd = pdir === "ltr" ? "lr" : "rl";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why this change is necessary. Can you create an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cconcolato Even though it is not entirely clear in TTML2, tts:direction, when specified on p, is intended to override tts:writingMode (at least when ipd is horizontal), otherwise the following test does not work: https://github.com/w3c/imsc-tests/blob/master/imsc1/ttml/direction/Direction003.ttml . It is not clear what is the intended effect of tts:direction specified on p when the ipd is vertical -- in the case of CSS, this overrides the ipd vertically, where ltr means tb and rtl means bt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See w3c/ttml2#1211

@palemieux palemieux merged commit 34d2dce into master Nov 21, 2020
@palemieux palemieux deleted the issues/0177-textAlign-processing branch November 18, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato cconcolato left review comments

Assignees

@palemieux palemieux

Labels
None yet
Projects
None yet
Milestone
1.1.2 Release
Development

Successfully merging this pull request may close these issues.

textAlign processing
2 participants
@palemieux @cconcolato