Skip to content

Commit

Permalink
Merge pull request #99 from vtamara/rubyzip-1.3
Browse files Browse the repository at this point in the history
Allows rubyzip >= 1.3.0 and fixes tests. Fixes #98
  • Loading branch information
sandrods authored Oct 10, 2019
2 parents c44bf0b + d656a1d commit e1bfd46
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ Gem for generating .odt files by making strings, images, tables and sections rep

### NEW

* you can provide an `io:` param to the report, so you can use templates stored in the database.
* now uses rubyzip ~> **1.2.0**
* uses newer rubyzip >= **1.3.0**

## INSTALL

Expand Down
2 changes: 1 addition & 1 deletion lib/odf-report/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module ODFReport
VERSION = "0.6.0"
VERSION = "0.6.1"
end
2 changes: 1 addition & 1 deletion odf-report.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "faker"
s.add_development_dependency "launchy"

s.add_runtime_dependency('rubyzip', "~> 1.2.0")
s.add_runtime_dependency('rubyzip', ">= 1.3.0")
s.add_runtime_dependency('nokogiri', ">= 1.5.0")

end
4 changes: 2 additions & 2 deletions spec/fields_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
expect(table).not_to match(/\[COLUMN_02\]/)
expect(table).to match(/\[COLUMN_03\]/)

expect(table).to match(item.id)
expect(table).to match(item.id.to_s)
expect(table).to match(item.name)

end
Expand All @@ -67,7 +67,7 @@

section = @data.xml.xpath(".//text:section[@text:name='SECTION_01_#{idx+1}']").to_s

expect(section).to match(item.id)
expect(section).to match(item.id.to_s)
expect(section).to match(item.name)

end
Expand Down

0 comments on commit e1bfd46

Please sign in to comment.