-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getref feature for NCBI's Bacterial Antimicrobial Resistance Reference Gene Database #269
Conversation
Hi @schultzm, thanks for the PR. Should be able to merge early next week. |
Could you try changing the python version from 3.5 to 3.6 in .travis.yml and commit that to the PR. Hopefully that will allow the Travis build to pass, as matplotlib requires 3.6. Also, could you add the ncbi option into the help text at line 65 of scripts/ariba. Thanks. |
@kpepper changes made as requested. Travis build now passes. Thanks. |
Hi @schultzm, |
Hi
ARIBA
team,With this pull request, the user can now do
ariba getref ncbi ncbi.getref
to download the Bacterial Antimicrobial Resistance Reference Gene Database of over 4000 curated AMR genes. Unitests have been put in place, which can be run for the new feature doingpython3 ariba/ariba/tests/ncbi_getter_test.py
. I have updated the version number to2.14.0
.Cheers,
Mark