Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getref feature for NCBI's Bacterial Antimicrobial Resistance Reference Gene Database #269

Merged
merged 14 commits into from
Jun 4, 2019

Conversation

schultzm
Copy link
Contributor

Hi ARIBA team,

With this pull request, the user can now do ariba getref ncbi ncbi.getref to download the Bacterial Antimicrobial Resistance Reference Gene Database of over 4000 curated AMR genes. Unitests have been put in place, which can be run for the new feature doing python3 ariba/ariba/tests/ncbi_getter_test.py . I have updated the version number to 2.14.0.

Cheers,

Mark

@kpepper
Copy link
Member

kpepper commented May 31, 2019

Hi @schultzm, thanks for the PR. Should be able to merge early next week.

@kpepper
Copy link
Member

kpepper commented Jun 3, 2019

Could you try changing the python version from 3.5 to 3.6 in .travis.yml and commit that to the PR. Hopefully that will allow the Travis build to pass, as matplotlib requires 3.6. Also, could you add the ncbi option into the help text at line 65 of scripts/ariba. Thanks.

@schultzm
Copy link
Contributor Author

schultzm commented Jun 4, 2019

@kpepper changes made as requested. Travis build now passes. Thanks.

@kpepper kpepper merged commit 2203c7f into sanger-pathogens:master Jun 4, 2019
@kpepper
Copy link
Member

kpepper commented Jun 11, 2019

Hi @schultzm,
Was there any particular reason for removing the following line from the MANIFEST.in:
recursive-include third_party *.h
I think it's causing the PyPi/Bioconda builds to fall over as the compiler can't find "bseq.h" - the PyPi tar is missing the .h files.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants