Handle megares 2.0.0 #295
Merged
Handle megares 2.0.0 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Martin, this is great! Are you taking over support again? :-P |
|
@puethe I don't have time to support properly, sorry. Can make time for important bug fixes like this one though! Will get travis working - hopefully won't take too many commits... |
|
There you go. If you're happy to merge, can you make a new release please? I've no idea what the release process is now. |
|
Thanks a lot @martinghunt . Will merge and increment the patch number. Release process - DockerHub and BioConda should pick up automatically. PyPi is manual, but can do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #287 and #294.
megares changed the filenames and format of their download between versions 1.0.1 and 2.0.0. This PR fixes
ariba getrefso that it works for all available versions (<=2.0.0) of megares at the time of writing.