Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract extension methods from AstSchemaBuilder #421

Closed

Conversation

Axxiss
Copy link

@Axxiss Axxiss commented Nov 21, 2018

As discussed #418 (comment) this PR aims to settle the ground for decoupling schema extension from materialization.

Creates a new trait AstSchemaExtender which contains all schema extension methods definition as originally defined in AstSchemaBuilder.

Furthermore, it creates a new default AstSchemaExtender implementation moving the implementation from DefaultAstSchemaBuilder to DefaultAstSchemaExtender

In order to keep backwards compatibility AstSchemaBuilder signature remains unchanged with the following tradeoffs

  • AstSchemaBuilder extends AstSchemaExtender
  • DefaultAstSchemaBuilder extends DefaultAstSchemaExtender

@Axxiss Axxiss mentioned this pull request Nov 23, 2018
@travisbrown
Copy link
Contributor

@Axxiss Would you want to make a case for this change going into 2.0? We're hoping to finalise what will be in it this week.

@Axxiss
Copy link
Author

Axxiss commented Nov 7, 2019

@travisbrown given the current situation with sangria. As this PR only moves code around without adding any value to end users, I think we can leave this out for now and wait for the next iteration.

If the new organization still want to move forward with #418 I will create the PR in the new repo.

@Axxiss Axxiss closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants