Extract extension methods from AstSchemaBuilder #421
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #418 (comment) this PR aims to settle the ground for decoupling schema extension from materialization.
Creates a new trait
AstSchemaExtender
which contains all schema extension methods definition as originally defined inAstSchemaBuilder
.Furthermore, it creates a new default
AstSchemaExtender
implementation moving the implementation fromDefaultAstSchemaBuilder
toDefaultAstSchemaExtender
In order to keep backwards compatibility
AstSchemaBuilder
signature remains unchanged with the following tradeoffsAstSchemaBuilder
extendsAstSchemaExtender
DefaultAstSchemaBuilder
extendsDefaultAstSchemaExtender