Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker image publish GitHub Action #2799

Closed
wants to merge 1 commit into from

Conversation

ChihweiLHBird
Copy link
Member

It stopped working in the last release due to the name change of PyPI publish action.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner August 13, 2023 05:11
@ChihweiLHBird ChihweiLHBird requested a review from a team August 13, 2023 05:11
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.043% ⚠️

Comparison is base (6a89f4b) 88.783% compared to head (1d5cc92) 88.740%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2799       +/-   ##
=============================================
- Coverage   88.783%   88.740%   -0.043%     
=============================================
  Files           92        92               
  Lines         7052      7052               
  Branches      1197      1197               
=============================================
- Hits          6261      6258        -3     
- Misses         542       544        +2     
- Partials       249       250        +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChihweiLHBird
Copy link
Member Author

Not sure why the docs lint CI is broken, but it looks irrelevant to this change. It runs well on my local machine with the same pip, wheel, and setuptools versions.

It seems to be related to patch version does not appear in the requirement string of autodocsumm package, but the weird part is it never complain this elsewhere.

    × python setup.py egg_info did not run successfully.
  Collecting aioquic
    │ exit code: 1
    ╰─> [3 lines of output]
        error in autodocsumm setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; .* suffix can only be used with `==` or `!=` operators
            Sphinx>=2.2.*
                  ~~~~~~^
        [end of output]
    
    note: This error originates from a subprocess, and is likely not a problem with pip.
  error: metadata-generation-failed

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this?

@ChihweiLHBird
Copy link
Member Author

ChihweiLHBird commented Aug 13, 2023

What's the purpose of this?

For making this action works. Currently the trigger is "when a workflow named Publish Artifacts is completed", since the Publish Artifacts workflow was renamed to Upload Python Package, we will need to change it in this trigger accordingly.

@ChihweiLHBird ChihweiLHBird requested a review from ahopkins August 13, 2023 17:55
@prryplatypus
Copy link
Member

This PR will be superseded by #2808 , as the whole actions flow has been reworked :D

@ChihweiLHBird ChihweiLHBird force-pushed the zhiwei/fix-docker-image-publish-gha branch from e41cf0d to 1d5cc92 Compare August 26, 2023 19:36
@ChihweiLHBird
Copy link
Member Author

Appreciated it! @prryplatypus

@ahopkins I think this is ready to be reviewed.

@ChihweiLHBird ChihweiLHBird deleted the zhiwei/fix-docker-image-publish-gha branch August 26, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants