Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: small fix to class name #2888

Merged
merged 2 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: Publish release
on:
release:
types: [created]
workflow_dispatch:

env:
IS_TEST: false
Expand Down Expand Up @@ -70,7 +69,7 @@ jobs:
tags="${tag_year}.${tag_month}"

if [[ "${tag_month}" == "12" ]]; then
tags+=",LTS"
tags+=",lts"
echo "::notice::Tag ${tag} is LTS version"
else
echo "::notice::Tag ${tag} is not LTS version"
Expand Down Expand Up @@ -123,7 +122,7 @@ jobs:
name: Publish Docker / Python ${{ matrix.python-version }}
needs: [generate_info, publish_package]
runs-on: ubuntu-latest
if: ${{ needs.generate_info.IS_TEST == 'false' }}
if: ${{ needs.generate_info.outputs.is-test == 'false' }}
strategy:
fail-fast: true
matrix:
Expand Down
2 changes: 1 addition & 1 deletion guide/content/en/plugins/sanic-ext/logger.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Logging can sometimes be an expensive operation. By pushing all logging off to a

## How does it work

When enabled, the extension will create a `multoprocessing.Queue`. It will remove all handlers on the [default Sanic loggers](../../guide/best-practices/logging.md) and replace them with a [`QueueHandler`](https://docs.python.org/3/library/logging.handlers.html#queuehandler). When a message is logged, it will be pushed into the queue by the handler, and read by the background process to the log handlers that were originally in place. This means you can still configure logging as normal and it should "just work."
When enabled, the extension will create a `multiprocessing.Queue`. It will remove all handlers on the [default Sanic loggers](../../guide/best-practices/logging.md) and replace them with a [`QueueHandler`](https://docs.python.org/3/library/logging.handlers.html#queuehandler). When a message is logged, it will be pushed into the queue by the handler, and read by the background process to the log handlers that were originally in place. This means you can still configure logging as normal and it should "just work."

## Configuration

Expand Down
Loading