Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "mint green" from color (#1764) #71

Merged
merged 4 commits into from
Sep 30, 2019

Conversation

sanikkenway
Copy link
Owner

The list of colors are all single words except for "mint green".

As mint green is a pretty obscure color and doesn't fit with the format of every other color being a single word.

I purpose we remove this color for consistency.

Issue#

Example:

https://github.com/faker-ruby/faker/issues/XXX

OR

No-Story

Description:

Describe what this PR does in a few lines. If you are adding a new faker generator, please tell us how you're going to use this object. Use cases are important because we need to make sure that our faker generators are useful. After adding the description, please delete this line.

ro-savage and others added 4 commits September 26, 2019 23:15
The list of colors are all single words except for "mint green".

As mint green is a pretty obscure color and doesn't fit with the format of every other color being a single word.

I purpose we remove this color for consistency.
This also makes the restaurant class methods explicit so they
can be documented.
* Fix some rubocop comments that were showing up in YARD docs.

* Fix the Rubocop command in Faker::Avatar as well.
@sanikkenway sanikkenway merged commit 61b38fc into sanikkenway:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants