Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compile even more components #7886

Draft
wants to merge 19 commits into
base: next
Choose a base branch
from
Draft

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Nov 26, 2024

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:54pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:54pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:54pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 11:54pm

Copy link
Contributor

No changes to documentation

@stipsan stipsan force-pushed the compile-even-more-components branch from 7befea3 to 0d73cdd Compare November 26, 2024 21:41
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Component Testing Report Updated Nov 26, 2024 11:43 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 50s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 19s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 47s 11 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 26, 2024

⚡️ Editor Performance Report

Updated Tue, 26 Nov 2024 23:45:48 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 25.0 efps (40ms) -4ms (-9.1%)
article (body) 59.5 efps (17ms) 59.7 efps (17ms) -0ms (-0.3%)
article (string inside object) 25.0 efps (40ms) 27.0 efps (37ms) -3ms (-7.5%)
article (string inside array) 20.8 efps (48ms) 22.7 efps (44ms) -4ms (-8.3%)
recipe (name) 50.0 efps (20ms) 52.6 efps (19ms) -1ms (-5.0%)
recipe (description) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) -1ms (-/-%)
synthetic (title) 16.4 efps (61ms) 16.9 efps (59ms) -2ms (-3.3%)
synthetic (string inside object) 16.9 efps (59ms) 17.2 efps (58ms) -1ms (-1.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 48ms 54ms 175ms 212ms 11.7s
article (body) 17ms 19ms 24ms 177ms 196ms 5.4s
article (string inside object) 40ms 42ms 49ms 169ms 192ms 7.1s
article (string inside array) 48ms 52ms 61ms 243ms 403ms 7.9s
recipe (name) 20ms 22ms 32ms 45ms 0ms 7.0s
recipe (description) 18ms 19ms 22ms 35ms 0ms 4.6s
recipe (instructions) 7ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 61ms 69ms 82ms 438ms 1133ms 14.4s
synthetic (string inside object) 59ms 63ms 74ms 337ms 777ms 9.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 44ms 58ms 187ms 207ms 11.5s
article (body) 17ms 19ms 22ms 171ms 229ms 5.4s
article (string inside object) 37ms 41ms 45ms 108ms 234ms 6.8s
article (string inside array) 44ms 47ms 57ms 77ms 154ms 7.4s
recipe (name) 19ms 20ms 25ms 39ms 0ms 7.0s
recipe (description) 17ms 19ms 21ms 38ms 0ms 4.5s
recipe (instructions) 7ms 8ms 9ms 11ms 0ms 3.3s
synthetic (title) 59ms 61ms 70ms 340ms 1023ms 14.4s
synthetic (string inside object) 58ms 62ms 76ms 375ms 835ms 9.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@stipsan stipsan force-pushed the compile-even-more-components branch from 706c5f0 to 2073bf6 Compare November 26, 2024 22:16
@stipsan stipsan changed the title Compile even more components feat: compile even more components Nov 26, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Carolina Gonzalez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants