[Wf-Diagnostics] add timeout error to failures

sankari165 · Oct 9, 2024 · 5a8d0b4 · 5a8d0b4
1 parent 74ec9b1
commit 5a8d0b4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/service/worker/diagnostics/invariant/failure/failure.go b/service/worker/diagnostics/invariant/failure/failure.go
@@ -84,6 +84,9 @@ func errorTypeFromReason(reason string) ErrorType {
 	if strings.Contains(reason, "Panic") {
 		return PanicError
 	}
+	if strings.Contains(reason, "Timeout") {
+		return TimeoutError
+	}
 	return CustomError
 }
 

diff --git a/service/worker/diagnostics/invariant/failure/failure_test.go b/service/worker/diagnostics/invariant/failure/failure_test.go
@@ -71,7 +71,7 @@ func Test__Check(t *testing.T) {
 				},
 				{
 					InvariantType: WorkflowFailed.String(),
-					Reason:        CustomError.String(),
+					Reason:        TimeoutError.String(),
 					Metadata:      metadataInBytes,
 				},
 			},
@@ -123,7 +123,7 @@ func failedWfHistory() *types.GetWorkflowExecutionHistoryResponse {
 				},
 				{
 					WorkflowExecutionFailedEventAttributes: &types.WorkflowExecutionFailedEventAttributes{
-						Reason:                       common.StringPtr("custom error"),
+						Reason:                       common.StringPtr("cadenceInternal:Timeout START_TO_CLOSE"),
 						Details:                      []byte("test-activity-failure"),
 						DecisionTaskCompletedEventID: 10,
 					},

diff --git a/service/worker/diagnostics/invariant/failure/types.go b/service/worker/diagnostics/invariant/failure/types.go
@@ -28,6 +28,7 @@ const (
 	CustomError  ErrorType = "The failure is caused by a specific custom error returned from the service code"
 	GenericError ErrorType = "The failure is because of an error returned from the service code"
 	PanicError   ErrorType = "The failure is caused by a panic in the service code"
+	TimeoutError ErrorType = "The failure is caused by a timeout during the execution"
 )
 
 func (e ErrorType) String() string {