Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_hana_preconfigure: Be less restrictive with new RHEL versions #511

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

berndfinger
Copy link
Member

Solves issue #500.

The new behavior if a system is running a RHEL version which is not in the list sap_hana_preconfigure_supported_rhel_minor_releases is as follows:

  1. role running in normal mode:

    a. sap_hana_preconfigure_min_rhel_release_check: false (default)
    The debug task Report if the system is running a RHEL release which is supported for SAP HANA displays a warning message.

    b. sap_hana_preconfigure_min_rhel_release_check: true
    The assert task Fail if the system is running a RHEL release which may not be supported for SAP HANA fails with a failure message.

  2. role running in assert mode, sap_hana_preconfigure_assert: true:

    a. sap_hana_preconfigure_min_rhel_release_check: false (default)
    The assert task Report if the RHEL release is supported for SAP HANA displays a warning message but the warning(error) is always ignored, so the playbook continues.

    b. sap_hana_preconfigure_min_rhel_release_check: true
    The assert task Assert that the system is running a RHEL release which is supported for SAP HANA fails with a failure message.

Solves issue sap-linuxlab#500.

The new behavior if a system is running a RHEL version which is not in
the list 'sap_hana_preconfigure_supported_rhel_minor_releases' is as follows:
1 - role running in normal mode:
  a - sap_hana_preconfigure_min_rhel_release_check: false (default)
      The debug task "Report if the system is running a RHEL release
        which is supported for SAP HANA" displays a warning message.
  b - sap_hana_preconfigure_min_rhel_release_check: true
      The assert task "Fail if the system is running a RHEL release
        which may not be supported for SAP HANA" fails with a
        failure message.
2 - role running in assert mode, sap_hana_preconfigure_assert: true:
  a - sap_hana_preconfigure_min_rhel_release_check: false (default)
      The assert task "Report if the RHEL release is supported for SAP
        HANA" displays a warning message but the warning(error) is always
        ignored, so the playbook continues.
  b - sap_hana_preconfigure_min_rhel_release_check: true
      The assert task "Assert that the system is running a RHEL release
        which is supported for SAP HANA" fails with a failure message.
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@berndfinger berndfinger merged commit bdd9190 into sap-linuxlab:dev Nov 14, 2023
1 check passed
@berndfinger berndfinger deleted the issue-500 branch November 14, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants