Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_general_preconfigure: cleanup for ansible-lint 6.22.0 #550

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

berndfinger
Copy link
Member

Solves issue #535.

@berndfinger berndfinger marked this pull request as draft December 14, 2023 14:12
@berndfinger
Copy link
Member Author

I will also cleanup the other two preconfigure roles as part of this PR. So I converted this PR to draft.

@berndfinger
Copy link
Member Author

I have trouble with diverged branches for which I do not have time to solve right now, so going back from Draft to standard PR now.

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rainerleber rainerleber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berndfinger berndfinger marked this pull request as ready for review December 15, 2023 10:39
@berndfinger berndfinger merged commit a317e32 into sap-linuxlab:dev Dec 15, 2023
2 checks passed
@berndfinger berndfinger deleted the issue-535-new branch December 15, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants